Add singletons for AwsCredentialsResolver impls#1059
Merged
Conversation
kstich
force-pushed
the
dev/kstich/AwsCredentialsResolver_instances
branch
from
335fad0 to
72a737d
Compare
mtdowling
requested changes
Mar 11, 2026
...oftware/amazon/smithy/java/aws/client/core/identity/EnvironmentVariableIdentityResolver.java
Outdated
Show resolved
Hide resolved
kstich
force-pushed
the
dev/kstich/AwsCredentialsResolver_instances
branch
from
72a737d to
91bb0bf
Compare
mtdowling
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
These resolvers have no state, so add singletons like several other stateless plugins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.